Skip to content

Commit

Permalink
roachtest: fix tests to not use go get
Browse files Browse the repository at this point in the history
`go get` no longer works the same in g1.18.

Release note: None
  • Loading branch information
rafiss committed Jul 26, 2022
1 parent 9495e9c commit f448cfa
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/gopg.go
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ func registerGopg(r registry.Registry) {
// We pipe the test output into go-junit-report tool which will output
// it in XML format.
fmt.Sprintf(`cd %s &&
GOPATH=%s go get -u github.com/jstemmer/go-junit-report &&
GOPATH=%s go install github.com/jstemmer/go-junit-report@latest &&
cat %s | %s/bin/go-junit-report`,
destPath, goPath, resultsFilePath, goPath),
)
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/gorm.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func registerGORM(r registry.Registry) {
// Install go-junit-report to convert test results to .xml format we know
// how to work with.
if err := repeatRunE(
ctx, t, c, node, "install go-junit-report", fmt.Sprintf("GOPATH=%s go get -u github.com/jstemmer/go-junit-report", goPath),
ctx, t, c, node, "install go-junit-report", fmt.Sprintf("GOPATH=%s go install github.com/jstemmer/go-junit-report@latest", goPath),
); err != nil {
t.Fatal(err)
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/libpq.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func registerLibPQ(r registry.Registry) {
// Install go-junit-report to convert test results to .xml format we know
// how to work with.
err = repeatRunE(ctx, t, c, node, "install go-junit-report",
fmt.Sprintf("GOPATH=%s go get -u github.com/jstemmer/go-junit-report", goPath),
fmt.Sprintf("GOPATH=%s go install github.com/jstemmer/go-junit-report@latest", goPath),
)
require.NoError(t, err)

Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/pgx.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ func registerPgx(r registry.Registry) {

t.Status("installing go-junit-report")
if err := repeatRunE(
ctx, t, c, node, "install go-junit-report", "go get -u github.com/jstemmer/go-junit-report",
ctx, t, c, node, "install go-junit-report", "go install github.com/jstemmer/go-junit-report@latest",
); err != nil {
t.Fatal(err)
}
Expand Down

0 comments on commit f448cfa

Please sign in to comment.