Merge #108484

108484: roachtest: better failure message for c2c roachtests r=lidorcarmel a=lidorcarmel In some failures cases the c2c roachtests may try to cutover even though the replication did not start successfully. This patch makes sure we fail with a more clear error in those cases. Epic: none Fixes: #107935 Release note: None Co-authored-by: Lidor Carmel <[email protected]>
cockroachdb · Aug 10, 2023 · eff0185 · eff0185
2 parents 74909fe + ca67d56
commit eff0185
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/pkg/cmd/roachtest/tests/cluster_to_cluster.go b/pkg/cmd/roachtest/tests/cluster_to_cluster.go
@@ -749,6 +749,8 @@ func (rd *replicationDriver) main(ctx context.Context) {
 	rd.checkParticipatingNodes(ingestionJobID)
 
 	retainedTime := rd.getReplicationRetainedTime()
+	require.GreaterOrEqual(rd.t, cutoverTime, retainedTime,
+		"cannot cutover to a time below the retained time (did the test already fail?)")
 
 	rd.metrics.cutoverTo = newMetricSnapshot(metricSnapper, cutoverTime)
 	rd.metrics.cutoverStart = newMetricSnapshot(metricSnapper, timeutil.Now())