Skip to content

Commit

Permalink
roachtest: terminate gossip roachtest on VM migration
Browse files Browse the repository at this point in the history
We've seen unexpected clock jumps in this test's failures. Live
migrations are one explanation for this, so let's disable them for this
test.

NB: Not closing out the linked issue as it happened on Azure, and this
termination policy only applies to GCE.

Informs #130737

Release note: None
  • Loading branch information
arulajmani committed Jan 7, 2025
1 parent 41e76d2 commit ef4ab13
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/cmd/roachtest/tests/gossip.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/option"
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/registry"
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/roachtestutil"
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/spec"
"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test"
"github.com/cockroachdb/cockroach/pkg/gossip"
"github.com/cockroachdb/cockroach/pkg/roachprod"
Expand Down Expand Up @@ -137,7 +138,7 @@ SELECT node_id
r.Add(registry.TestSpec{
Name: "gossip/chaos/nodes=9",
Owner: registry.OwnerKV,
Cluster: r.MakeClusterSpec(9),
Cluster: r.MakeClusterSpec(9, spec.TerminateOnMigration()),
CompatibleClouds: registry.AllExceptAWS,
Suites: registry.Suites(registry.Nightly),
Leases: registry.MetamorphicLeases,
Expand Down

0 comments on commit ef4ab13

Please sign in to comment.