Skip to content

Commit

Permalink
colexec: make sure to init child op chains in AND and OR operators
Browse files Browse the repository at this point in the history
Previously, we forgot to call `Init` on the side operator chains of AND
and OR projection operators, and this is now fixed. The impact of the
bug is minor though (like a nil context when the tracing is enabled).

Release justification: bug fix.

Release note: None
  • Loading branch information
yuzefovich committed Aug 22, 2022
1 parent c32478f commit eeee919
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
12 changes: 12 additions & 0 deletions pkg/sql/colexec/and_or_projection.eg.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pkg/sql/colexec/and_or_projection_tmpl.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@ func (o *_OP_LOWERProjOp) Init(ctx context.Context) {
return
}
o.input.Init(o.Ctx)
o.leftProjOpChain.Init(o.Ctx)
o.rightProjOpChain.Init(o.Ctx)
}

// Next is part of the colexecop.Operator interface.
Expand Down

0 comments on commit eeee919

Please sign in to comment.