Merge #93217

93217: ui: add go scheduling latency graph to Overload dashboard r=irfansharif a=irfansharif Release note (ui change): We added a goroutine scheduling latency graph to the Overload dashboard in the UI. It shows what the per-node p99 scheduling latency is for goroutines. <img width="979" alt="image" src="https://user-images.githubusercontent.com/10536690/206282495-7869a2ea-e8eb-4ed9-9ce3-05fb3ac59ad2.png"> Co-authored-by: irfan sharif <[email protected]>
cockroachdb · Dec 8, 2022 · ec095bc · ec095bc
2 parents db4b418 + 99dee35
commit ec095bc
Showing 1 changed file with 21 additions and 1 deletion.
diff --git a/pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/overload.tsx b/pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/overload.tsx
@@ -42,6 +42,26 @@ export default function (props: GraphDashboardProps) {
       </Axis>
     </LineGraph>,
 
+    <LineGraph
+      title="Goroutine Scheduling Latency: 99th percentile"
+      sources={nodeSources}
+      tooltip={`P99 scheduling latency for goroutines`}
+    >
+      <Axis units={AxisUnits.Duration} label="latency">
+        {nodeIDs.map(nid => (
+          <>
+            <Metric
+              key={nid}
+              name="cr.node.go.scheduler_latency-p99"
+              title={nodeDisplayName(nodeDisplayNameByID, nid)}
+              sources={[nid]}
+              downsampleMax
+            />
+          </>
+        ))}
+      </Axis>
+    </LineGraph>,
+
     <LineGraph
       title="Runnable Goroutines per CPU"
       sources={nodeSources}
@@ -213,7 +233,7 @@ export default function (props: GraphDashboardProps) {
     </LineGraph>,
 
     <LineGraph title="Admission Delay: 75th percentile" sources={nodeSources}>
-      <Axis label="delay for requests that waited (nanos)">
+      <Axis units={AxisUnits.Duration} label="delay for requests that waited">
         {nodeIDs.map(nid => (
           <>
             <Metric