Skip to content

Commit

Permalink
Merge #128614
Browse files Browse the repository at this point in the history
128614: roachtest: revert workload cpu change for all ycsb variants r=renatolabs a=DarrylWong

Epic: none
Release note: none
Fixes: #128529

Co-authored-by: DarrylWong <[email protected]>
  • Loading branch information
craig[bot] and DarrylWong committed Aug 8, 2024
2 parents 167a9af + c99ea36 commit e103ae1
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions pkg/cmd/roachtest/tests/ycsb.go
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ func registerYCSB(r registry.Registry) {
Name: fmt.Sprintf("zfs/ycsb/%s/nodes=3/cpu=%d", wl, cpus),
Owner: registry.OwnerStorage,
Benchmark: true,
Cluster: r.MakeClusterSpec(4, spec.CPU(cpus), spec.WorkloadNode(), spec.SetFileSystem(spec.Zfs)),
Cluster: r.MakeClusterSpec(4, spec.CPU(cpus), spec.WorkloadNode(), spec.WorkloadNodeCPU(cpus), spec.SetFileSystem(spec.Zfs)),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runYCSB(ctx, t, c, wl, cpus, ycsbOptions{})
},
Expand All @@ -142,7 +142,7 @@ func registerYCSB(r registry.Registry) {
Name: fmt.Sprintf("%s/isolation-level=read-committed", name),
Owner: registry.OwnerTestEng,
Benchmark: true,
Cluster: r.MakeClusterSpec(4, spec.CPU(cpus), spec.WorkloadNode()),
Cluster: r.MakeClusterSpec(4, spec.CPU(cpus), spec.WorkloadNode(), spec.WorkloadNodeCPU(cpus)),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runYCSB(ctx, t, c, wl, cpus, ycsbOptions{readCommitted: true})
},
Expand All @@ -156,7 +156,7 @@ func registerYCSB(r registry.Registry) {
Name: fmt.Sprintf("%s/mvcc-range-keys=global", name),
Owner: registry.OwnerTestEng,
Benchmark: true,
Cluster: r.MakeClusterSpec(4, spec.CPU(cpus), spec.WorkloadNode()),
Cluster: r.MakeClusterSpec(4, spec.CPU(cpus), spec.WorkloadNode(), spec.WorkloadNodeCPU(cpus)),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runYCSB(ctx, t, c, wl, cpus, ycsbOptions{rangeTombstone: true})
},
Expand All @@ -175,7 +175,7 @@ func registerYCSB(r registry.Registry) {
Name: fmt.Sprintf("%s/uniform", name),
Owner: registry.OwnerTestEng,
Benchmark: true,
Cluster: r.MakeClusterSpec(4, spec.CPU(cpus), spec.WorkloadNode()),
Cluster: r.MakeClusterSpec(4, spec.CPU(cpus), spec.WorkloadNode(), spec.WorkloadNodeCPU(cpus)),
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
runYCSB(ctx, t, c, wl, cpus, ycsbOptions{uniformDistribution: true})
},
Expand Down

0 comments on commit e103ae1

Please sign in to comment.