Skip to content

Commit

Permalink
Merge pull request #84114 from knz/backport-78255-211
Browse files Browse the repository at this point in the history
  • Loading branch information
knz authored Jul 22, 2022
2 parents 5df10fe + 6d558f8 commit d03dba5
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 25 deletions.
2 changes: 0 additions & 2 deletions docs/generated/eventlog.md
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,6 @@ An event of type `set_cluster_setting` is recorded when a cluster setting is cha
Events in this category are generated when a table has been
marked as audited via `ALTER TABLE ... EXPERIMENTAL_AUDIT SET`.

{% include {{ page.version.version }}/misc/experimental-warning.md %}

Note: These events are not written to `system.eventlog`, even
when the cluster setting `system.eventlog.enabled` is set. They
are only emitted via external logging.
Expand Down
6 changes: 3 additions & 3 deletions pkg/acceptance/compose/gss/psql/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# Build the test binary in a multistage build.
FROM golang:1.15 AS builder
FROM golang:1.16 AS builder
WORKDIR /workspace
COPY . .
RUN go get -d -t -tags gss_compose
RUN go test -v -c -tags gss_compose -o gss.test
RUN GO111MODULE=off go get -d -t -tags gss_compose
RUN GO111MODULE=off go test -v -c -tags gss_compose -o gss.test

# Copy the test binary to an image with psql and krb installed.
FROM postgres:11
Expand Down
32 changes: 16 additions & 16 deletions pkg/util/log/eventpb/sql_audit_events.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions pkg/util/log/eventpb/sql_audit_events.proto
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ message CommonSQLExecDetails {
// Events in this category are generated when a table has been
// marked as audited via `ALTER TABLE ... EXPERIMENTAL_AUDIT SET`.
//
// {% include {{ page.version.version }}/misc/experimental-warning.md %}
//
// Note: These events are not written to `system.eventlog`, even
// when the cluster setting `system.eventlog.enabled` is set. They
// are only emitted via external logging.
Expand Down
4 changes: 2 additions & 2 deletions pkg/util/log/logconfig/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ import (

"github.com/cockroachdb/cockroach/pkg/util/log/logpb"
"github.com/cockroachdb/errors"
"github.com/dustin/go-humanize"
"gopkg.in/yaml.v2"
humanize "github.com/dustin/go-humanize"
yaml "gopkg.in/yaml.v2"
)

// DefaultFileFormat is the entry format for file sinks when not
Expand Down

0 comments on commit d03dba5

Please sign in to comment.