Merge #37775

37775: tree: handle null in suboperator expressions r=rafiss a=rafiss

Before this change, a null right operand in a suboperator would cause an
unhandled error. We were receiving stack trace reports from the wild.
Add a test and fix it.

fixes #37547 
Release note (bug fix): a null right operand now causes the suboperator
expression to return null

Co-authored-by: Rafi Shamim <[email protected]>

pkg/sql/sem/tree/eval.go

@@ -3674,7 +3674,9 @@ func (expr *ComparisonExpr) Eval(ctx *EvalContext) (Datum, error) {
 	if op.hasSubOperator() {
 		var datums Datums
 		// Right is either a tuple or an array of Datums.
-		if tuple, ok := AsDTuple(right); ok {
+		if !expr.fn.NullableArgs && right == DNull {
+			return DNull, nil
+		} else if tuple, ok := AsDTuple(right); ok {
 			datums = tuple.D
 		} else if array, ok := AsDArray(right); ok {
 			datums = array.Array

pkg/sql/sem/tree/testdata/eval/any_some_all

@@ -70,6 +70,69 @@ eval
 ----
 NULL
 
+# Regression test for #37547 - ensure that null RHS of comparisons with
+# suboperators are correctly handled. A null RHS always results in null.
+eval
+1 = ANY(NULL::int[])
+----
+NULL
+
+eval
+1 = SOME(NULL::int[])
+----
+NULL
+
+eval
+1 = ALL(NULL::int[])
+----
+NULL
+
+eval
+NULL::int = ANY(NULL::int[])
+----
+NULL
+
+eval
+NULL::int = SOME(NULL::int[])
+----
+NULL
+
+eval
+NULL::int = ALL(NULL::int[])
+----
+NULL
+
+# A null LHS has different behavior if the array is empty or not
+eval
+NULL::int = ANY(ARRAY[1,2])
+----
+NULL
+
+eval
+NULL::int = SOME(ARRAY[1,2])
+----
+NULL
+
+eval
+NULL::int = ALL(ARRAY[1,2])
+----
+NULL
+
+eval
+NULL::int = ANY(ARRAY[]::int[])
+----
+false
+
+eval
+NULL::int = SOME(ARRAY[]::int[])
+----
+false
+
+eval
+NULL::int = ALL(ARRAY[]::int[])
+----
+true
+
 eval
 1 = ALL (ARRAY[1, 2, NULL])
 ----