Skip to content

Commit

Permalink
storage: EncodeMVCCValueForExport does not inline
Browse files Browse the repository at this point in the history
Epic: none
Release note: None
  • Loading branch information
stevendanna committed Mar 11, 2024
1 parent 8454009 commit b8ae5f0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 3 additions & 2 deletions pkg/sql/importer/import_mvcc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,9 @@ func TestMVCCValueHeaderImportEpoch(t *testing.T) {
Key: startKey,
EndKey: endKey,
},
MVCCFilter: kvpb.MVCCFilter_All,
StartTime: hlc.Timestamp{},
MVCCFilter: kvpb.MVCCFilter_All,
StartTime: hlc.Timestamp{},
IncludeMVCCValueHeader: true,
}

header := kvpb.Header{Timestamp: s.Clock().Now()}
Expand Down
2 changes: 0 additions & 2 deletions pkg/storage/mvcc_value.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,6 @@ func (v MVCCValue) SafeFormat(w redact.SafePrinter, _ rune) {

// EncodeMVCCValueForExport strips fields from the MVCCValueHeader that
// should not get exported out of the cluster.
//
//gcassert:inline
func EncodeMVCCValueForExport(mvccValue MVCCValue) ([]byte, error) {
// Consider a fast path, where only the roachpb.Value gets exported.
// Currently, this only occurs if the value was not imported.
Expand Down

0 comments on commit b8ae5f0

Please sign in to comment.