Merge #119852

119852: changefeedccl: deflake TestAlterChangefeedPersistSinkURI r=stevendanna a=andyyang890 This patch deflakes `TestAlterChangefeedPersistSinkURI` by setting `jobs.NewTestingKnobsWithShortIntervals`. Previously, if the changefeed job's status was set to `pause-requested` before it started running, the job would record an error when it attempted to start running and become unclaimed. This had the potential of causing the test to time out before the job could be reclaimed and properly paused. Now, the job should be promptly reclaimed and paused. Fixes #119676 Release note: None Co-authored-by: Andy Yang <[email protected]>
cockroachdb · Mar 4, 2024 · b5e7608 · b5e7608
2 parents 1d79dd8 + 0f81a99
commit b5e7608
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/ccl/changefeedccl/alter_changefeed_test.go b/pkg/ccl/changefeedccl/alter_changefeed_test.go
@@ -710,7 +710,11 @@ func TestAlterChangefeedPersistSinkURI(t *testing.T) {
 	const unredactedSinkURI = "null://blah?AWS_ACCESS_KEY_ID=the_secret"
 
 	ctx := context.Background()
-	srv, rawSQLDB, _ := serverutils.StartServer(t, base.TestServerArgs{})
+	srv, rawSQLDB, _ := serverutils.StartServer(t, base.TestServerArgs{
+		Knobs: base.TestingKnobs{
+			JobsTestingKnobs: jobs.NewTestingKnobsWithShortIntervals(),
+		},
+	})
 	defer srv.Stopper().Stop(ctx)
 
 	s := srv.ApplicationLayer()