server/profiler: mark ActiveQueryDumpsEnabled as SystemVisible

This setting was miscategorized initially - the active query profiler
runs in both storage and virtual clusters, so it should be at least
SystemVisible, but maybe even ApplicationLevel.

Release note: None

docs/generated/settings/settings-for-tenants.txt

@@ -30,6 +30,7 @@ cloudstorage.timeout	duration	10m0s	the timeout for import/export storage operat
 cluster.auto_upgrade.enabled	boolean	true	disable automatic cluster version upgrade until reset	application
 cluster.organization	string		organization name	system-visible
 cluster.preserve_downgrade_option	string		disable (automatic or manual) cluster version upgrade from the specified version until reset	application
+diagnostics.active_query_dumps.enabled	boolean	true	experimental: enable dumping of anonymized active queries to disk when node is under memory pressure	system-visible
 diagnostics.forced_sql_stat_reset.interval	duration	2h0m0s	interval after which the reported SQL Stats are reset even if not collected by telemetry reporter. It has a max value of 24H.	application
 diagnostics.reporting.enabled	boolean	true	enable reporting diagnostic metrics to cockroach labs	application
 diagnostics.reporting.interval	duration	1h0m0s	interval at which diagnostics data should be reported	application

docs/generated/settings/settings.html

@@ -35,7 +35,7 @@
 <tr><td><div id="setting-cluster-auto-upgrade-enabled" class="anchored"><code>cluster.auto_upgrade.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>disable automatic cluster version upgrade until reset</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
 <tr><td><div id="setting-cluster-organization" class="anchored"><code>cluster.organization</code></div></td><td>string</td><td><code></code></td><td>organization name</td><td>Serverless/Dedicated/Self-Hosted (read-only)</td></tr>
 <tr><td><div id="setting-cluster-preserve-downgrade-option" class="anchored"><code>cluster.preserve_downgrade_option</code></div></td><td>string</td><td><code></code></td><td>disable (automatic or manual) cluster version upgrade from the specified version until reset</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
-<tr><td><div id="setting-diagnostics-active-query-dumps-enabled" class="anchored"><code>diagnostics.active_query_dumps.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>experimental: enable dumping of anonymized active queries to disk when node is under memory pressure</td><td>Dedicated/Self-Hosted</td></tr>
+<tr><td><div id="setting-diagnostics-active-query-dumps-enabled" class="anchored"><code>diagnostics.active_query_dumps.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>experimental: enable dumping of anonymized active queries to disk when node is under memory pressure</td><td>Serverless/Dedicated/Self-Hosted (read-only)</td></tr>
 <tr><td><div id="setting-diagnostics-forced-sql-stat-reset-interval" class="anchored"><code>diagnostics.forced_sql_stat_reset.interval</code></div></td><td>duration</td><td><code>2h0m0s</code></td><td>interval after which the reported SQL Stats are reset even if not collected by telemetry reporter. It has a max value of 24H.</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
 <tr><td><div id="setting-diagnostics-reporting-enabled" class="anchored"><code>diagnostics.reporting.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>enable reporting diagnostic metrics to cockroach labs</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
 <tr><td><div id="setting-diagnostics-reporting-interval" class="anchored"><code>diagnostics.reporting.interval</code></div></td><td>duration</td><td><code>1h0m0s</code></td><td>interval at which diagnostics data should be reported</td><td>Serverless/Dedicated/Self-Hosted</td></tr>

pkg/server/profiler/cluster_settings.go

@@ -21,7 +21,7 @@ import "github.com/cockroachdb/cockroach/pkg/settings"
 // Note: this feature only works for nodes running on unix hosts with cgroups
 // enabled.
 var ActiveQueryDumpsEnabled = settings.RegisterBoolSetting(
-	settings.SystemOnly,
+	settings.SystemVisible,
 	"diagnostics.active_query_dumps.enabled",
 	"experimental: enable dumping of anonymized active queries to disk when node is under memory pressure",
 	true,