Skip to content

Commit

Permalink
roachtest: ignore upstream flakes in activerecord and sequelize
Browse files Browse the repository at this point in the history
Both of these tests are being worked on upstream to resolve the
flakiness. Since CockroachDB itself is not the cause of the flakes, we
ignore them so that these tests don't create unnecessary issues.

Release note: None
  • Loading branch information
rafiss committed Aug 17, 2023
1 parent dc2c52d commit a02bdad
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
11 changes: 8 additions & 3 deletions pkg/cmd/roachtest/tests/activerecord.go
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,14 @@ func registerActiveRecord(r registry.Registry) {
results.failExpectedCount++
results.currentFailures = append(results.currentFailures, test)
case !pass && !expectedFailure:
results.results[test] = fmt.Sprintf("--- FAIL: %s (unexpected)", test)
results.failUnexpectedCount++
results.currentFailures = append(results.currentFailures, test)
// The test suite is flaky and work is being done upstream to stabilize
// it (https://github.com/cockroachdb/cockroach/issues/108938). Until
// that's done, we ignore all failures from this test.
// results.results[test] = fmt.Sprintf("--- FAIL: %s (unexpected)", test)
// results.failUnexpectedCount++
// results.currentFailures = append(results.currentFailures, test)
results.results[test] = fmt.Sprintf("--- SKIP: %s due to upstream flakes (https://github.com/cockroachdb/cockroach/issues/108938)", test)
results.ignoredCount++
}
results.runTests[test] = struct{}{}
}
Expand Down
6 changes: 5 additions & 1 deletion pkg/cmd/roachtest/tests/sequelize.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,11 @@ func registerSequelize(r registry.Registry) {
rawResultsStr := result.Stdout + result.Stderr
t.L().Printf("Test Results: %s", rawResultsStr)
if err != nil {
t.Fatal(err)
// The test suite is flaky and work is being done upstream to stabilize
// it (https://github.com/sequelize/sequelize/pull/15569). Until that's
// done, we ignore all failures from this test.
// t.Fatal(err)
t.L().Printf("ignoring failure (https://github.com/cockroachdb/cockroach/issues/108937): %s", err)
}
}

Expand Down

0 comments on commit a02bdad

Please sign in to comment.