Skip to content

Commit

Permalink
Merge #91843 #91864
Browse files Browse the repository at this point in the history
91843: roachtest: new passing test in pgjdbc test suite r=rafiss a=rafiss

fixes #91506
backport fixes #91500

Epic: None

Release note: None

91864: workload/schemachange: disable inserts due to flakes r=fqazi a=fqazi

Fixes: #91859

We started seeing flakes on the insert part of this workload, so let's temporarily disable them until we can find the cycles to the root cause of them. This patch temporarily disables the inserts in the workload.

Release note: None

Co-authored-by: Rafi Shamim <[email protected]>
Co-authored-by: Faizan Qazi <[email protected]>
  • Loading branch information
3 people committed Nov 16, 2022
3 parents d98d195 + 95ec1d5 + ea6ad56 commit 9184a8a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion pkg/cmd/roachtest/tests/pgjdbc_blocklist.go
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,6 @@ var pgjdbcBlockList = blocklist{
"org.postgresql.test.jdbc2.ServerErrorTest.testPrimaryKey": "27796",
"org.postgresql.test.jdbc2.StatementTest.testCloseInProgressStatement": "17511",
"org.postgresql.test.jdbc2.StatementTest.testConcurrentWarningReadAndClear": "17511",
"org.postgresql.test.jdbc2.StatementTest.testDateFunctions": "17511",
"org.postgresql.test.jdbc2.StatementTest.testFastCloses": "17511",
"org.postgresql.test.jdbc2.StatementTest.testParsingSemiColons": "17511",
"org.postgresql.test.jdbc2.StatementTest.testUpdateCount": "17511",
Expand Down
6 changes: 3 additions & 3 deletions pkg/workload/schemachange/operation_generator.go
Original file line number Diff line number Diff line change
Expand Up @@ -275,9 +275,9 @@ var opWeights = []int{
renameView: 1,
setColumnDefault: 1,
setColumnNotNull: 1,
setColumnType: 0, // Disabled and tracked with #66662.
survive: 0, // Disabled and tracked with #83831
insertRow: 10, // Temporarily reduced because of #80820
setColumnType: 0, // Disabled and tracked with #66662.
survive: 0, // Disabled and tracked with #83831
insertRow: 0, // Disabled and tracked with #91863
selectStmt: 10,
validate: 2, // validate twice more often
}
Expand Down

0 comments on commit 9184a8a

Please sign in to comment.