Skip to content

Commit

Permalink
kvserver: change default for kv.raft_log.loosely_coupled_truncation.e…
Browse files Browse the repository at this point in the history
…nabled to false

This is due to the regression noticed in
#78412

Release note: None
  • Loading branch information
sumeerbhola committed Apr 19, 2022
1 parent 81f47f1 commit 911a546
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion pkg/kv/kvserver/raft_log_queue.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,16 @@ import (
// - v22.1 and v22.2: If the setting has been changed to false the v22.1 nodes
// will do strongly coupled truncation and the v22.2 will do loosely
// coupled. This co-existence is correct.
// NB: The above comment is incorrect about the default value being true. Due
// to https://github.com/cockroachdb/cockroach/issues/78412 we have changed
// the default to false for v22.1.
// TODO(sumeer): update the above comment when we have a revised plan.
var looselyCoupledTruncationEnabled = func() *settings.BoolSetting {
s := settings.RegisterBoolSetting(
settings.SystemOnly,
"kv.raft_log.loosely_coupled_truncation.enabled",
"set to true to loosely couple the raft log truncation",
true)
false)
s.SetVisibility(settings.Reserved)
return s
}()
Expand Down

0 comments on commit 911a546

Please sign in to comment.