Skip to content

Commit

Permalink
Merge #83941
Browse files Browse the repository at this point in the history
83941: sql/catalog/descs: fix typo r=ajwerner a=ajwerner

Release note: None

Co-authored-by: Andrew Werner <[email protected]>
  • Loading branch information
craig[bot] and ajwerner committed Jul 8, 2022
2 parents 365b9c4 + f424ee0 commit 8edc7ba
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion pkg/sql/catalog/descs/descriptor.go
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ func (q *byIDLookupContext) lookupUncommitted(id descpb.ID) (_ catalog.Descripto
// Hydrate any types in the descriptor if necessary, for uncomitted
// descriptors we are going to include offline and get non-cached view.
if tableDesc, isTableDesc := ud.(catalog.TableDescriptor); isTableDesc {
ud, err = q.tc.hydrateTypesInTableDescWitOptions(q.ctx, q.txn, tableDesc, true, true)
ud, err = q.tc.hydrateTypesInTableDescWithOptions(q.ctx, q.txn, tableDesc, true, true)
if err != nil {
return nil, err
}
Expand Down
8 changes: 4 additions & 4 deletions pkg/sql/catalog/descs/hydrate.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,24 +25,24 @@ import (
)

// hydrateTypesInTableDesc installs user defined type metadata in all types.T
//// present in the input TableDescriptor. See hydrateTypesInTableDescWitOptions.
// present in the input TableDescriptor. See hydrateTypesInTableDescWithOptions.
func (tc *Collection) hydrateTypesInTableDesc(
ctx context.Context, txn *kv.Txn, desc catalog.TableDescriptor,
) (catalog.TableDescriptor, error) {
return tc.hydrateTypesInTableDescWitOptions(ctx,
return tc.hydrateTypesInTableDescWithOptions(ctx,
txn,
desc,
false, /* includeOffline */
false /*avoidLeased*/)
}

// hydrateTypesInTableDescWitOptions installs user defined type metadata in all types.T
// hydrateTypesInTableDescWithOptions installs user defined type metadata in all types.T
// present in the input TableDescriptor. It always returns the same type of
// TableDescriptor that was passed in. It ensures that ImmutableTableDescriptors
// are not modified during the process of metadata installation. Dropped tables
// do not get hydrated. Optionally, when hydrating types we can include offline
// descriptors and avoid leasing depending on the context.
func (tc *Collection) hydrateTypesInTableDescWitOptions(
func (tc *Collection) hydrateTypesInTableDescWithOptions(
ctx context.Context,
txn *kv.Txn,
desc catalog.TableDescriptor,
Expand Down

0 comments on commit 8edc7ba

Please sign in to comment.