Skip to content

Commit

Permalink
Merge #57075 #57081
Browse files Browse the repository at this point in the history
57075: colexec,bazel: re-work code-gen through bazel r=irfansharif a=irfansharif

Now that we've added a way to source a specific template file in
`execgen` (instead of relying on hard-coded paths, see #56982), we can
simplify how we generate eg.go files. This lets us parallelize the
generation of these files, as the more fine-grained dependency tracking
lets bazel generate each eg.go file concurrently (previously we had to
specify the superset of all template files as dependencies for the
generation of each individual eg.go file).

There's one exception for the generation of like_ops.eg.go, the
generation of which appears to want read from a second template file.
We've special-cased the generation of this file into it's own thing.

Release note: None

57081: roachtest: update pgjdbc blocklists r=solongordon a=solongordon

I made the following updates to the pgjdbc blocklists:
- Removed tests which are now passing due to user-defined schema
  support.
- Removed testUpdateSelectOnly since we now support this syntax as a
  no-op.
- Updated some failure reasons to "unknown" for tests which are still
  failing even though the referenced issue was closed.
- Added many BatchExecuteTest.* tests to the ignore list. These tests
  are flaky due to a combination of #54477 and the fact that the tests
  do not run in a deterministic order.

Fixes #53467
Fixes #53738
Fixes #54106

Release note: None

Co-authored-by: irfan sharif <[email protected]>
Co-authored-by: Solon Gordon <[email protected]>
  • Loading branch information
3 people committed Nov 25, 2020
3 parents 87bd652 + 4800cf2 + 4f071aa commit 8d25fa1
Show file tree
Hide file tree
Showing 3 changed files with 309 additions and 3,097 deletions.
Loading

0 comments on commit 8d25fa1

Please sign in to comment.