build: update nogo config to lint more generated code

To date we have used a regex like `cockroach/pkg/.*/.*\\.go` to identify
first-party code, which does find our checked-in code, but does *not*
match generated code, which is not staged at that path in the Bazel
sandbox. Instead, these generated files are generally found in
`bazel-out/.../bin`. In places where we've set `only_files`, in addition
to the original regex, we add another regex to capture these generated
files.

Many packages are now (correctly) being flagged as missing package-level
comments. In these cases I have added a very short package-level
comment.

Closes #102191.

Epic: none
Release note: None

pkg/base/license.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package base exposes basic utilities used across cockroach.
 package base
 
 import (

pkg/ccl/backupccl/backup_planning.go

@@ -6,6 +6,7 @@
 //
 //     https://github.com/cockroachdb/cockroach/blob/master/licenses/CCL.txt
 
+// Package backupccl implements backup logic.
 package backupccl
 
 import (

pkg/ccl/changefeedccl/schemafeed/schema_feed.go

@@ -6,6 +6,8 @@
 //
 //     https://github.com/cockroachdb/cockroach/blob/master/licenses/CCL.txt
 
+// Package schemafeed provides SchemaFeed, which can be used to track schema
+// updates.
 package schemafeed
 
 import (

pkg/ccl/sqlproxyccl/proxy.go

@@ -6,6 +6,7 @@
 //
 //     https://github.com/cockroachdb/cockroach/blob/master/licenses/CCL.txt
 
+// Package sqlproxyccl implements a server to proxy SQL connections.
 package sqlproxyccl
 
 import (

pkg/col/coldata/vec.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package coldata exposes utilities for handling columnarized data.
 package coldata
 
 import (

pkg/config/field.go

@@ -8,6 +8,8 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package config contains basic utilities and data definitions for zone
+// configuration.
 package config
 
 import "github.com/cockroachdb/redact"

pkg/kv/kvnemesis/kvnemesisutil/context.go

@@ -7,8 +7,8 @@
 // the Business Source License, use of this software will be governed
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
-//
 
+// Package kvnemesisutil provides basic utilities for kvnemesis.
 package kvnemesisutil
 
 import "context"

pkg/kv/kvpb/data.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package kvpb contains basic utilities for the kv layer.
 package kvpb
 
 import (

pkg/kv/kvserver/closedts/sidetransport/sender.go

@@ -8,6 +8,8 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package sidetransport contains definitions for the sidetransport layer of
+// the kvserver.
 package sidetransport
 
 import (

pkg/multitenant/tenantcapabilities/capability.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package tenantcapabilities describes the privileges allotted to tenants.
 package tenantcapabilities
 
 import (

pkg/roachprod/vm/aws/aws.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package aws provides functionality for the aws provider.
 package aws
 
 import (

pkg/spanconfig/spanconfigstore/store.go

@@ -8,6 +8,8 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package spanconfigstore exposes utilities for storing and retrieving
+// SpanConfigs associated with a single span.
 package spanconfigstore
 
 import (

pkg/sql/catalog/catalogkeys/keys.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package catalogkeys describes keys used by the SQL catalog.
 package catalogkeys
 
 import (

pkg/sql/catalog/descpb/descriptor.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package descpb exposes the "Descriptor" type and related utilities.
 package descpb
 
 import (

pkg/sql/colconv/batch.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package colconv exposes utilities for working with vectorized columns.
 package colconv
 
 import (

pkg/sql/colexec/colexeccmp/default_cmp_expr.go

@@ -8,6 +8,8 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package colexeccmp exposes some comparison definitions for vectorized
+// operations.
 package colexeccmp
 
 import (

pkg/sql/colexec/colexecspan/span_assembler.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package colexecspan implements utilities for manipulating spans.
 package colexecspan
 
 import (

pkg/sql/colfetcher/cfetcher.go

@@ -8,6 +8,8 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package colfetcher implements logic for fetching kv's and forming table rows
+// for an arbitrary number of tables.
 package colfetcher
 
 import (

pkg/sql/execinfra/base.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package execinfra contains the common interfaces for colexec and rowexec.
 package execinfra
 
 import (

pkg/sql/lexbase/encode.go

@@ -17,6 +17,7 @@
 
 // This code was derived from https://github.com/youtube/vitess.
 
+// Package lexbase contains utilities for lexing sql.
 package lexbase
 
 import (

pkg/sql/opt/exec/explain/explain_factory.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package explain implements "explaining" for cockroach.
 package explain
 
 import (

pkg/sql/opt/exec/factory.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package exec contains execution-related utilities. (See README.md.)
 package exec
 
 import (

pkg/sql/opt/memo/memo.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package memo exposes logic for `Memo`, the central data structure for `opt`.
 package memo
 
 import (

pkg/sql/opt/norm/factory.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package norm implements normalization for queries.
 package norm
 
 import (

pkg/sql/opt/xform/general_funcs.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package xform contains logic for transforming SQL queries.
 package xform
 
 import (

pkg/sql/parser/help.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package parser contains exposes a SQL parser for cockroach.
 package parser
 
 import (

pkg/sql/plpgsql/parser/lexbase/utils.go

@@ -8,4 +8,5 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package lexbase contains utilities for lexing plpgsql.
 package lexbase

pkg/sql/plpgsql/parser/parse.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package parser exposes a parser for plpgsql.
 package parser
 
 import (

pkg/sql/privilege/privilege.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package privilege outlines the basic privilege system for cockroach.
 package privilege
 
 import (

pkg/sql/schemachange/alter_column_type.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// schemachange contains utilities describing type conversions.
 package schemachange
 
 import (

pkg/sql/schemachanger/rel/internal/comparetest/schema.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package comparetest exposes a reltest.Suite.
 package comparetest
 
 import (

pkg/sql/schemachanger/rel/internal/cyclegraphtest/schema.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package cyclegraphtest contains test utilities and a "Suite" for reltest.
 package cyclegraphtest
 
 import (

pkg/sql/schemachanger/rel/internal/entitynodetest/schema.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package entitynodetest exposes a reltest.Suite.
 package entitynodetest
 
 import (

pkg/sql/schemachanger/scop/ops.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package scop describes ops within a schema change.
 package scop
 
 // Op represents an action to be taken on a single descriptor.

pkg/sql/schemachanger/scplan/internal/scgraph/graph.go

@@ -8,6 +8,8 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package scgraph contains utilities for describing a schema change operation
+// as a graph of screl nodes.
 package scgraph
 
 import (

pkg/storage/pebbleiter/BUILD.bazel

@@ -7,7 +7,7 @@ load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
 # keep
 go_library(
     name = "pebbleiter",
-    srcs = select({
+    srcs = ["pebbleiter.go"] + select({
         "//build/toolchains:crdb_test": [":gen-crdb-test-on"],
         "//conditions:default": [":gen-crdb-test-off"],
     }),

pkg/util/buildutil/crdb_test_off.go

@@ -11,6 +11,7 @@
 //go:build !crdb_test || crdb_test_off
 // +build !crdb_test crdb_test_off
 
+// Package buildutil provides a constant CrdbTestBuild.
 package buildutil
 
 // CrdbTestBuild is a flag that is set to true if the binary was compiled

pkg/util/buildutil/crdb_test_on.go

@@ -11,6 +11,7 @@
 //go:build crdb_test && !crdb_test_off
 // +build crdb_test,!crdb_test_off
 
+// Package buildutil provides a constant CrdbTestBuild.
 package buildutil
 
 // CrdbTestBuild is a flag that is set to true if the binary was compiled

pkg/util/encoding/encoding.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package encoding exposes some utilities for encoding data as bytes.
 package encoding
 
 import (

pkg/workload/schemachange/schemachange.go

@@ -8,6 +8,7 @@
 // by the Apache License, Version 2.0, included in the file
 // licenses/APL.txt.
 
+// Package schemachange implements the schemachange workload.
 package schemachange
 
 import (