Skip to content

Commit

Permalink
roachtest: remove some debugging printouts in tpch_concurrency
Browse files Browse the repository at this point in the history
This was added to track down the deadlock fixed in the previous commit,
so we no longer need it.

Release note: None
  • Loading branch information
yuzefovich committed Jul 14, 2022
1 parent 10c2cf9 commit 6189bb3
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions pkg/cmd/roachtest/tests/tpch_concurrency.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ package tests
import (
"context"
"fmt"
"strings"
"time"

"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster"
Expand Down Expand Up @@ -107,22 +106,6 @@ func registerTPCHConcurrency(r registry.Registry) {
// Run each query once on each connection.
for queryNum := 1; queryNum <= tpch.NumQueries; queryNum++ {
t.Status("running Q", queryNum)
// To aid during the debugging later, we'll print the DistSQL
// diagram of the query.
rows, err := conn.Query("EXPLAIN (DISTSQL) " + tpch.QueriesByNumber[queryNum])
if err != nil {
return err
}
defer rows.Close()
for rows.Next() {
var line string
if err = rows.Scan(&line); err != nil {
t.Fatal(err)
}
if strings.Contains(line, "Diagram:") {
t.Status(line)
}
}
// The way --max-ops flag works is as follows: the global ops
// counter is incremented **after** each worker completes a
// single operation, so it is possible for all connections start
Expand Down

0 comments on commit 6189bb3

Please sign in to comment.