Skip to content

Commit

Permalink
Merge #83698
Browse files Browse the repository at this point in the history
83698: streamingccl: update a couple test skips r=miretskiy a=stevendanna

- TestPartitionedStreamReplicationClient now references the first
  issue I hit when running this under the race detector.

- TestTenantStreamingSuccessfulIngestion is now only skipped under
  StressRace. I've run it locally and while this test is slow under
  stress and race, I think it is probably worth it to run our main e2e
  test under race for a bit.

Release note: None

Co-authored-by: Steven Danna <[email protected]>
  • Loading branch information
craig[bot] and stevendanna committed Jul 1, 2022
2 parents 8794cf2 + 0292d39 commit 5d279a0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func (f *subscriptionFeedSource) Close(ctx context.Context) {}

func TestPartitionedStreamReplicationClient(t *testing.T) {
defer leaktest.AfterTest(t)()
skip.UnderRaceWithIssue(t, 77916, "flaky test")
skip.UnderRaceWithIssue(t, 83694)
defer log.Scope(t).Close(t)

h, cleanup := streamingtest.NewReplicationHelper(t,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,7 @@ func TestTenantStreamingSuccessfulIngestion(t *testing.T) {
defer leaktest.AfterTest(t)()
defer log.Scope(t).Close(t)

skip.UnderRace(t, "slow under race")
skip.UnderStress(t, "slow under stress")
skip.UnderStressRace(t, "slow under stressrace")

dataSrv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.Method == "GET" {
Expand Down

0 comments on commit 5d279a0

Please sign in to comment.