spanconfig/store: improve commentary, tests and naming

Release note: None

build/bazelutil/check.sh

@@ -24,6 +24,7 @@ pkg/security/securitytest/securitytest.go://go:generate go-bindata -mode 0600 -m
 pkg/security/securitytest/securitytest.go://go:generate gofmt -s -w embedded.go
 pkg/security/securitytest/securitytest.go://go:generate goimports -w embedded.go
 pkg/server/api_v2.go://go:generate swagger generate spec -w . -o ../../docs/generated/swagger/spec.json --scan-models
+pkg/spanconfig/spanconfigstore/span_store.go://go:generate ../../util/interval/generic/gen.sh *entry spanconfigstore
 pkg/sql/conn_fsm.go://go:generate ../util/fsm/gen/reports.sh TxnStateTransitions stateNoTxn
 pkg/sql/opt/optgen/lang/gen.go://go:generate langgen -out expr.og.go exprs lang.opt
 pkg/sql/opt/optgen/lang/gen.go://go:generate langgen -out operator.og.go ops lang.opt

pkg/gen/misc.bzl

@@ -7,8 +7,8 @@ MISC_SRCS = [
   "//pkg/kv/kvserver/spanlatch:latch_interval_btree_test.go",
   "//pkg/roachpb:batch_generated.go",
   "//pkg/roachprod/vm/aws:terraform/main.tf",
-  "//pkg/spanconfig/spanconfigstore:spanconfigstoreentry_interval_btree.go",
-  "//pkg/spanconfig/spanconfigstore:spanconfigstoreentry_interval_btree_test.go",
+  "//pkg/spanconfig/spanconfigstore:entry_interval_btree.go",
+  "//pkg/spanconfig/spanconfigstore:entry_interval_btree_test.go",
   "//pkg/sql/lexbase:keywords.go",
   "//pkg/sql/lexbase:reserved_keywords.go",
   "//pkg/sql/lexbase:tokens.go",

pkg/spanconfig/spanconfigreconciler/reconciler.go

@@ -263,7 +263,7 @@ func (f *fullReconciler) reconcile(
 	// KV, in order to delete them. After doing so, we'll issue those same
 	// deletions against this copy in order for it to reflect an up-to-date view
 	// of span configs.
-	storeWithLatestSpanConfigs = storeWithExistingSpanConfigs.Copy(ctx)
+	storeWithLatestSpanConfigs = storeWithExistingSpanConfigs.Clone()
 
 	// Delete all updated spans in a store populated with all current records.
 	// Because our translation above captures the entire SQL state, deleting all

pkg/spanconfig/spanconfigstore/BUILD.bazel

@@ -8,7 +8,7 @@ go_library(
         "span_store.go",
         "store.go",
         "system_store.go",
-        ":spanconfigstoreentry_interval_btree.go",  # keep
+        ":entry_interval_btree.go",  # keep
     ],
     importpath = "github.com/cockroachdb/cockroach/pkg/spanconfig/spanconfigstore",
     visibility = ["//visibility:public"],
@@ -33,7 +33,7 @@ go_test(
         "span_store_test.go",
         "store_test.go",
         "system_store_test.go",
-        ":spanconfigstoreentry_interval_btree_test.go",  # keep
+        ":entry_interval_btree_test.go",  # keep
     ],
     data = glob(["testdata/**"]),
     embed = [":spanconfigstore"],
@@ -46,7 +46,6 @@ go_test(
         "//pkg/testutils",
         "//pkg/util/hlc",
         "//pkg/util/leaktest",
-        "//pkg/util/log",
         "//pkg/util/randutil",
         "@com_github_cockroachdb_datadriven//:datadriven",
         "@com_github_stretchr_testify//require",
@@ -56,5 +55,5 @@ go_test(
 gen_interval_btree(
     name = "spanconfig_interval_btree",
     package = "spanconfigstore",
-    type = "*spanConfigStoreEntry",
+    type = "*entry",
 )