-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
105383: concurrency: split out replicated/unreplicated lock holder information r=nvanbenschoten a=arulajmani The MVCC keyspace is the source of truth for replicated locks. We've previously concluded that trying to keep the in-memory state of replicated locks in sync is fraught with subtle issues. We instead do the dumb thing and forget replicated locks in a few places (see comment about mvccResolveWriteIntent in tryUpdateLockLocked). It follows that we don't need to track as much information about replicated locks (like we do for unreplicated locks). For example, we do not need to track the sequence number history for replicated locks. This patch splits out lock holder information about replicated locks and unreplicated locks into 2 different structs. As mentioned above, we no longer track seqeunce numbers for the former. Informs #102270 Release note: None 105641: kvserver: deflake TestProtectedTimestamps r=irfansharif a=arulajmani This patch fixes a few (hopefully all) issues with TestProtectedTimestamps. In particular, - The range max bytes used by the test was broken after the lower bound was bumped in a37e053. We up the value. - There was flakiness at various points in the test as a result of lease transfers. We change the test to run on a single node test cluster to get around this. Fixes: #93497 Release note: None Co-authored-by: Arul Ajmani <[email protected]>
- Loading branch information
Showing
29 changed files
with
585 additions
and
486 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.