Skip to content

Commit

Permalink
kvserver: de-flake TestStoreSplitRangeLookupRace
Browse files Browse the repository at this point in the history
Fixes #75198. This test was a bit brittle in expecting only one kind of
range lookup request in a testing filter -- it was always possible to
intercept a ReverseScanRequest, and after enabling span configs
(#73876), we now have an internal query ("validate-span-cfgs") that
makes use of it. See #75198 for more details.

Release note: None
  • Loading branch information
irfansharif committed Jan 21, 2022
1 parent 96779a6 commit 38a65a9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/kv/kvserver/client_split_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3018,7 +3018,7 @@ func TestStoreSplitRangeLookupRace(t *testing.T) {
select {
case <-blockRangeLookups:
if kv.TestingIsRangeLookup(ba) &&
ba.Requests[0].GetInner().(*roachpb.ScanRequest).Key.Equal(bounds.Key.AsRawKey()) {
ba.Requests[0].GetInner().Header().Key.Equal(bounds.Key.AsRawKey()) {

select {
case rangeLookupIsBlocked <- struct{}{}:
Expand Down

0 comments on commit 38a65a9

Please sign in to comment.