Skip to content

Commit

Permalink
kv: remove assertion around QuotaPool and Raft window size config
Browse files Browse the repository at this point in the history
This check was well intentioned when added, but seems misguided
in retrospect. There are valid reasons why someone might want to
configure limits to various dimensions of the Raft window size
in ways that, when combined, exceeds the total window size limit
(i.e. the quota pool size).
  • Loading branch information
nvanbenschoten authored and JuanLeon1 committed Nov 18, 2020
1 parent ed70083 commit 03a6d4a
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions pkg/base/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -413,9 +413,6 @@ func (cfg *RaftConfig) SetDefaults() {
if cfg.RaftProposalQuota > int64(cfg.RaftMaxUncommittedEntriesSize) {
panic("raft proposal quota should not be above max uncommitted entries size")
}
if cfg.RaftProposalQuota < int64(cfg.RaftMaxSizePerMsg)*int64(cfg.RaftMaxInflightMsgs) {
panic("raft proposal quota should not be below per-replica replication window size")
}
}

// RaftElectionTimeout returns the raft election timeout, as computed from the
Expand Down

0 comments on commit 03a6d4a

Please sign in to comment.