Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks: Fix OpenShift instances #575

Merged
merged 1 commit into from
Feb 15, 2024
Merged

tasks: Fix OpenShift instances #575

merged 1 commit into from
Feb 15, 2024

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Feb 15, 2024

Commit 93523ff broke OpenShift deployments: The export HOME from setup-tasks isn't visible in the main cockpit-tasks loop, so the GitHub API fails to resolve the user's home dir.

Put it back for now. This is far from elegant, but we need to unbreak the statistics queue quickly.


http://webhook-cockpit.apps.ocp.cloud.ci.centos.org/inspect-queue is building up a lot of pending statistics requests, it fails with

Traceback (most recent call last):
File "/work/bots/./run-queue", line 36, in <module>
from task import distributed_queue
File "/work/bots/task/__init__.py", line 51, in <module>
api = github.GitHub()
^^^^^^^^^^^^^^^
File "/work/bots/task/github.py", line 157, in __init__
self.log = Logger(self.cache.directory)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/work/bots/task/github.py", line 71, in __init__
os.makedirs(directory, exist_ok=True)
File "<frozen os>", line 215, in makedirs
File "<frozen os>", line 225, in makedirs
PermissionError: [Errno 13] Permission denied: '/.cache'

@martinpitt
Copy link
Member Author

Crap, it still fails, no idea now.

Commit 93523ff broke OpenShift deployments: The `export HOME`
from `setup-tasks` isn't visible in the main `cockpit-tasks` loop, so
the GitHub API fails to resolve the user's home dir.

Put it back for now. This is far from elegant, but we need to unbreak
the statistics queue quickly.
@martinpitt martinpitt marked this pull request as ready for review February 15, 2024 17:15
@martinpitt
Copy link
Member Author

OK, fixed, deployed, and it's catching up with the statistics queue now.

@martinpitt martinpitt requested a review from jelly February 15, 2024 17:16
@jelly jelly merged commit 9e9c0ab into main Feb 15, 2024
4 checks passed
@jelly jelly deleted the fix-home-openshift branch February 15, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants