Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fedora-logos in the Dockerfile #566

Closed
wants to merge 1 commit into from
Closed

Add fedora-logos in the Dockerfile #566

wants to merge 1 commit into from

Conversation

KKoukiou
Copy link
Contributor

Needed by anaconda-webui RPM.

Needed by anaconda-webui RPM.
martinpitt
martinpitt previously approved these changes Nov 16, 2023
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll trigger a build, but these refreshes tend to break pixel tests and such, so we'll need to work through all our projects tomorrow. But that's ok.

@martinpitt
Copy link
Member

Triggered a build: https://github.com/cockpit-project/cockpituous/actions/runs/6893507798 . This will trickle into the bots by tomorrow, but I can also make sure to re-deploy it synchronously.

@martinpitt
Copy link
Member

@KKoukiou While it's harmless, I still wonder why -- shouldn't this be a runtime dependency, not a build-time one? And even if it's a build-time one, build should happen in a VM, not on the host. You'd never rpm-install anaconda-webui.rpm inside the tasks container.

I refreshed my local cockpit/tasks toolbox with this rebuild, and locally ran the podman tests on f39.

@martinpitt martinpitt dismissed their stale review November 16, 2023 16:38

this doesn't make sense yet

@martinpitt
Copy link
Member

I rolled this out as it doesn't seem to cause too many regressions (and I hope these are naughties), and it's good to refresh the container from time to time anyway. So you should be unblocked, but please fix the build/binary dependencies of this. Not landing yet, until we discussed that.

@KKoukiou
Copy link
Contributor Author

You 're right, build is happening in the VM, this is not needed.

@KKoukiou KKoukiou closed this Nov 16, 2023
@martinpitt martinpitt deleted the fedora-logos branch November 16, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants