Various fixes for OpenShift #9701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are trailing commas in the 'Member of' listing on the Project page. Lets clean them out
These had bad styling, indentation and text.
These strings should be translated.
Openshift now has a new namespace for apis, ignore this one too
For example URLs like:
https://10.111.112.101:8443/apis/rbac.authorization.k8s.io/v1beta1/namespaces/testprojectuserproj/rolebindings?watch=true&resourceVersion=2896: couldn't connect: Connection refused
I've seen races here on my own machine when running the tests. Once I log back in, everything is in the expected state, it just takes longer sometimes to actually undeploy KubeVirt Closes cockpit-project#9701
martinpitt
force-pushed
the
kubernetes-fixes
branch
from
8eaa0b9 to
da3ef46
Compare
2 tasks
|
All tests succeeded for me locally, with |
|
This is formally my PR (so I can't self-approve), but all commits are from @stefwalter. :+1 from me. |
stefwalter
approved these changes
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split out the five "safe" commits from @stefwalter's #9530. The two other cause regressions, and need to be investigated separately.