cockpit-components-terminal: change onFocusIn/OnFocusOut to onFocus/onBlur #9342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mareklibra
changed the title
44 tasks
martinpitt
reviewed
Jun 11, 2018
| onFocusIn={this.onFocusIn} | ||
| onFocusOut={this.onFocusOut} />; | ||
| onFocus={this.onFocusIn} | ||
| onBlur={this.onFocusOut} />; |
There was a problem hiding this comment.
These events don't work with react-lite, the handler is never called. So either both properties should be set for a transitional period, or this is blocked on actually switching to React. At that point the handler methods should be renamed accordingly, too.
martinpitt
added
the
blocked
mareklibra
changed the title
|
Let's keep it blocked till #9263 lands. |
martinpitt
removed
the
blocked
|
#9263 landed now, unblocking. |
…onBlur React ceased to support onFocusIn/onFocusOut (facebook/react#6274). Closes cockpit-project#9342
martinpitt
force-pushed
the
react.cockpit-components-terminal
branch
from
7e77b96 to
4bad7a5
Compare
|
Rebased to current master and adjusted commit log a bit. This might even be a regression from the react switch, thus priority. |
martinpitt
approved these changes
Sep 23, 2018
garrett
pushed a commit
to garrett/cockpit
that referenced
this pull request
Oct 17, 2018
…onBlur React ceased to support onFocusIn/onFocusOut (facebook/react#6274). Closes cockpit-project#9342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9263 PR-split, see individual commits for more info.