Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Stop using ostree trivial-httpd #5680

Closed

Conversation

cgwalters
Copy link
Contributor

I'm trying to add a libcurl backend to ostree, and I'd like people to stop using
trivial-httpd; it was a mistake to have it be command line API.

Related: ostreedev/ostree#636

(Note I didn't test this commit)

I'm trying to add a libcurl backend to ostree, and I'd like people to stop using
trivial-httpd; it was a mistake to have it be command line API.

Related: ostreedev/ostree#636

(Note I didn't test this commit)
@petervo
Copy link
Contributor

petervo commented Jan 4, 2017

I think we'd be better off just hard coding the port. We know what's running in these test machines to avoid conflicts. The reason for not doing that before was that trivial httpd didn't support the port option on all versions.

Also we probably want to make sure we stop the process.

@cgwalters, if you'd rather not modify this PR, I'm working on some ostree test changes now and I can just incorporate this in with them.

@cgwalters
Copy link
Contributor Author

Sure, that sounds fine. Regarding stopping, we could pick up the PDEATHSIG code from toolbox maybe.

@stefwalter
Copy link
Contributor

Tests are failing with:

Traceback (most recent call last):
  File "/var/lib/testvm/atomic.install", line 280, in <module>
    cockpit_installer.run()
  File "/var/lib/testvm/atomic.install", line 256, in run
    self.switch_to_local_tree()
  File "/var/lib/testvm/atomic.install", line 89, in switch_to_local_tree
    m = re.search(pattern, webserver_status)

@petervo
Copy link
Contributor

petervo commented Jan 5, 2017

Yeah I'm reworking this. We have to make the script actually run properly. I'll open a pr soon.

@petervo petervo closed this Jan 5, 2017
stefwalter pushed a commit that referenced this pull request Jan 5, 2017
trivial-httpd will be depreciated.

Related: ostreedev/ostree#636

Closes #5680
Closes #5682
Reviewed-by: Stef Walter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants