tools: Split out cockpit-ssh into its own subpackage

[stefwalter]

Both the dashboard and cockpit-ssh process go into this subpackage: cockpit-dashboard

Note that until we have a stable interface between cockpit-ws and its authentication processes, we need to require identical versions between cockpit-ws and cockpit-dashboard.

In addition for the time being we have cockpit-ws unconditionally require cockpit-dashboard.

• Update packaging
• Decide on a good name: cockpit-dashboard

Depends on:

• tools: Rename cockpit-shell to cockpit-system #5600

[petervo]

This breaks the kubernetes container where we want cockpit-ws and nothing else.

Long term i don't think we want cockpit-ws depending on cockpit-dashboard, but that's blocking on removing the secondary machines logic from cockpit-ws. Is there a reason to do this before that work is done?

If we do then we can work around the installation issues in the container scripts.

[stefwalter]

Okay, so I've reversed the dependency now that we have #5658 and the LoginTo option.

[stefwalter]

Added a commit to return "not-supported" when cockpit-ssh is not present.

[petervo]

The kubernetes container needs cockpit-ssh. For the node tests.

Right now we only install cockpit-ws into the cockpit/ws container (https://github.com/cockpit-project/cockpit/blob/master/test/images/scripts/lib/atomic.install#L171). We need to install cockpit-ssh in there as well.

[stefwalter]

Priority, part of today's sprint deadline.

[petervo]

Disabling most of the multi machine tests on atomic worries me a little. We've found a lot of OS bugs by running those. I realize we can't install cockpit-dashboard on atomic while it's bundled with cockpit-ssh. Is this a good enough reason to just make the cockpit-ssh package now?

[stefwalter]

Disabling most of the multi machine tests on atomic worries me a little. We've found a lot of OS bugs by running those. I realize we can't install cockpit-dashboard on atomic while it's bundled with cockpit-ssh. Is this a good enough reason to just make the cockpit-ssh package now?

Aren't we going to end up in exactly this situation anyway long term, where cockpit-dashboard/cockpit-ssh won't be available on Atomic? If we work around this now we're just delaying inevitable.

[petervo]

Yeah good point, though I think it's worth working towards getting it back in at some point. Something something modularity something something containers.