storage: Allow Anaconda to override feature detection #21150
+222
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
force-pushed
the
storage-anaconda-feature-config
branch
2 times, most recently
from
f0ea950 to
09c0e1a
Compare
This was referenced Oct 22, 2024
|
@M4rtinK, would this be what Anaconda needs? |
mvollmer
force-pushed
the
storage-anaconda-feature-config
branch
from
09c0e1a to
94addba
Compare
|
I think this is still valuable to us. |
Alright! I get this into shape. |
mvollmer
force-pushed
the
storage-anaconda-feature-config
branch
2 times, most recently
from
b6a6f65 to
102d69f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mvollmer
force-pushed
the
storage-anaconda-feature-config
branch
from
102d69f to
5552b5b
Compare
cockpituous
reviewed
Jan 10, 2025
Comment on lines
+897
to
+898
| } catch (error) { | ||
| console.warn("Can't enable storaged btrfs module", error.toString()); |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
Comment on lines
+911
to
+912
| } catch (error) { | ||
| console.warn("Can't enable storaged iscsi module", error.toString()); |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
Comment on lines
+924
to
+925
| } catch (error) { | ||
| console.warn("Can't enable storaged lvm2 module", error.toString()); |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
Comment on lines
+931
to
+933
| if (!client.anaconda_feature("vdo")) { | ||
| client.features.lvm_create_vdo = false; | ||
| return Promise.resolve(); |
There was a problem hiding this comment.
These 3 added lines are not executed by any test.
Comment on lines
+941
to
+943
| if (!client.anaconda_feature("legacy-vdo")) { | ||
| client.features.legacy_vdo = false; | ||
| return Promise.resolve(); |
There was a problem hiding this comment.
These 3 added lines are not executed by any test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #20844.