Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the patternfly group with 6 updates #20962

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Bump the patternfly group with 6 updates #20962

merged 3 commits into from
Sep 4, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 1, 2024 •
edited
Loading

Bumps the patternfly group with 6 updates:

Package From To
@patternfly/patternfly 5.3.1 5.4.0
@patternfly/react-core 5.3.4 5.4.0
@patternfly/react-icons 5.3.2 5.4.0
@patternfly/react-styles 5.3.1 5.4.0
@patternfly/react-table 5.3.4 5.4.0
@patternfly/react-tokens 5.3.1 5.4.0

Updates @patternfly/patternfly from 5.3.1 to 5.4.0

Release notes

Sourced from @​patternfly/patternfly's releases.

v5.4.0

What's Changed

... (truncated)

Commits
  • f75001a Update issue templates
  • a9e2a7a Update issue templates
  • c0c2559 Update and rename PF6_alpha_bug_request.md to PF6_beta_bug_request.md (#6935)
  • fec6266 chore(deps): update dependency @​patternfly/documentation-framework to v5.16.1...
  • 1550c08 chore(deps): update dependency @​patternfly/documentation-framework to v5.16.1...
  • ca9b9e6 fix(InlineEdit): updated example to match React (#6877)
  • d5ee3d9 chore(build): corepack use [email protected] (#6872)
  • 50182be chore(deps): update dependency @​patternfly/react-code-editor to v5.3.4 (#6859)
  • aad6f30 fix(form): support label addl info in horizontal form (#6853)
  • baa5f63 chore(deps): update dependency @​patternfly/react-table to v5.3.4 (#6861)
  • Additional commits viewable in compare view

Updates @patternfly/react-core from 5.3.4 to 5.4.0

Commits
  • 3ef073a chore(release): releasing packages [ci skip]
  • 7a25feb chore: Update promote.sh to promote to npm.
  • 494143d chore: Update promote.sh with dry run
  • 5836008 Revert "chore(release): Update promote.sh"
  • 5937183 chore(release): Update promote.sh
  • 701ccd9 Revert "chore(release): releasing packages [ci skip]"
  • 48c08cb chore(release): releasing packages [ci skip]
  • a76ba5e chore(release): releasing packages [ci skip]
  • 279c54f fix(Table): remove blank scope in empty deprecated table headers (#10875)
  • 7b64b05 Update issue templates
  • Additional commits viewable in compare view

Updates @patternfly/react-icons from 5.3.2 to 5.4.0

Commits
  • 3ef073a chore(release): releasing packages [ci skip]
  • 7a25feb chore: Update promote.sh to promote to npm.
  • 494143d chore: Update promote.sh with dry run
  • 5836008 Revert "chore(release): Update promote.sh"
  • 5937183 chore(release): Update promote.sh
  • 701ccd9 Revert "chore(release): releasing packages [ci skip]"
  • 48c08cb chore(release): releasing packages [ci skip]
  • a76ba5e chore(release): releasing packages [ci skip]
  • 279c54f fix(Table): remove blank scope in empty deprecated table headers (#10875)
  • 7b64b05 Update issue templates
  • Additional commits viewable in compare view

Updates @patternfly/react-styles from 5.3.1 to 5.4.0

Updates @patternfly/react-table from 5.3.4 to 5.4.0

Commits
  • 3ef073a chore(release): releasing packages [ci skip]
  • 7a25feb chore: Update promote.sh to promote to npm.
  • 494143d chore: Update promote.sh with dry run
  • 5836008 Revert "chore(release): Update promote.sh"
  • 5937183 chore(release): Update promote.sh
  • 701ccd9 Revert "chore(release): releasing packages [ci skip]"
  • 48c08cb chore(release): releasing packages [ci skip]
  • a76ba5e chore(release): releasing packages [ci skip]
  • 279c54f fix(Table): remove blank scope in empty deprecated table headers (#10875)
  • 7b64b05 Update issue templates
  • Additional commits viewable in compare view

Updates @patternfly/react-tokens from 5.3.1 to 5.4.0

Commits
  • 3ef073a chore(release): releasing packages [ci skip]
  • 7a25feb chore: Update promote.sh to promote to npm.
  • 494143d chore: Update promote.sh with dry run
  • 5836008 Revert "chore(release): Update promote.sh"
  • 5937183 chore(release): Update promote.sh
  • 701ccd9 Revert "chore(release): releasing packages [ci skip]"
  • 48c08cb chore(release): releasing packages [ci skip]
  • a76ba5e chore(release): releasing packages [ci skip]
  • 279c54f fix(Table): remove blank scope in empty deprecated table headers (#10875)
  • 7b64b05 Update issue templates
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@github-actions github-actions bot changed the title [no-test]: Bump the patternfly group with 6 updates Bump the patternfly group with 6 updates Sep 1, 2024
@allisonkarlitskaya allisonkarlitskaya force-pushed the dependabot/npm_and_yarn/patternfly-f0d83b27e1 branch 2 times, most recently from 4e22955 to 4e3ba23 Compare September 1, 2024 03:47
@martinpitt
Copy link
Member

Not refreshing as there are several pixel failures here which need to be investigated first.

@martinpitt martinpitt added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Sep 1, 2024
@jelly
Copy link
Member

jelly commented Sep 2, 2024 •
edited
Loading

Not refreshing as there are several pixel failures here which need to be investigated first.

With that you mean, this one? I don't see any other

https://cockpit-logs.us-east-1.linodeobjects.com/pull-20962-4e3ba23c-20240901-034748-fedora-40-other/log.html

It misses the left right arrows

@martinpitt
Copy link
Member

@jelly ah right, storage is a known flake. I think it's not really "missing" the arrows, at first sight it is just scrolled differently horizontally?

@jelly
Copy link
Member

jelly commented Sep 2, 2024 •
edited
Loading

@jelly ah right, storage is a known flake. I think it's not really "missing" the arrows, at first sight it is just scrolled differently horizontally?

Maybe, needs some investigation:

image

Locally this looks fine, the breakpoint starts at about ~435 and the screenshot is 414 exactly and I can't really reproduce this scenario locally.

The test has some history:

        b.set_layout("mobile")
        # Waiting a bit for the layout to stabilize.  The scrolling of
        # the header happens asynchronously with an animation.
        time.sleep(2)
        # Now scroll the header all the way to the left to get a conistent pixel test result
        nav_scroll_btn = ".services-header button[aria-label='Scroll back']"
        while b.call_js_func("ph_attr", nav_scroll_btn, "disabled") is None:
            b.click(nav_scroll_btn)
            time.sleep(0.5)

So with TEST_SHOW_BROWSER=pixels ./test/verify/check-system-services -vst TestServices.testFilter this is reproducible.

@jelly
Copy link
Member

jelly commented Sep 2, 2024

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/patternfly-f0d83b27e1 branch from 4e3ba23 to 9534d37 Compare September 2, 2024 14:41
@allisonkarlitskaya allisonkarlitskaya force-pushed the dependabot/npm_and_yarn/patternfly-f0d83b27e1 branch from 9534d37 to 1cc90c3 Compare September 2, 2024 16:03
@jelly jelly removed the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Sep 3, 2024
@jelly
Copy link
Member

jelly commented Sep 3, 2024

Needs a node_modules update but let's wait till the tests pass.

@jelly jelly added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Sep 3, 2024
@jelly
Copy link
Member

jelly commented Sep 3, 2024

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/patternfly-f0d83b27e1 branch from 1f9b707 to 5b050ba Compare September 3, 2024 15:09
@allisonkarlitskaya allisonkarlitskaya force-pushed the dependabot/npm_and_yarn/patternfly-f0d83b27e1 branch from 5b050ba to 1e6776f Compare September 3, 2024 16:42
@jelly jelly removed the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Sep 3, 2024
@jelly
Copy link
Member

jelly commented Sep 4, 2024

This keeps failing on when the modified test continues after switching back to desktop layout. Loading all the services just takes a ... while.

@jelly jelly force-pushed the dependabot/npm_and_yarn/patternfly-f0d83b27e1 branch from 0c6ca64 to 9d66609 Compare September 4, 2024 08:55
@jelly
Copy link
Member

jelly commented Sep 4, 2024

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/patternfly-f0d83b27e1 branch from 9d66609 to 106e296 Compare September 4, 2024 09:10
@jelly jelly added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Sep 4, 2024
@dependabot
Bump the patternfly group with 6 updates
419b120 
Dependabot couldn't find the original pull request head commit, 5b050ba.
@allisonkarlitskaya allisonkarlitskaya force-pushed the dependabot/npm_and_yarn/patternfly-f0d83b27e1 branch from 106e296 to 419b120 Compare September 4, 2024 09:18
@jelly jelly mentioned this pull request Sep 4, 2024
Closed
23 tasks
jelly added 2 commits September 4, 2024 11:26
@jelly
test: workaround PF 5.4.0 breakpoint issue with ServiceTabs
1f72a47 
Resizing to a mobile layout does not trigger the NavList to show the
buttons on the left and right to scroll through the list. They do show
up when refreshing the page.
@jelly
test: only run pixel tests code in the pixel tests scenario
1256ab2
@jelly jelly removed the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Sep 4, 2024
@jelly jelly requested review from mvollmer and tomasmatus September 4, 2024 10:12
@jelly jelly merged commit c062fd7 into main Sep 4, 2024
80 of 82 checks passed
@jelly jelly deleted the dependabot/npm_and_yarn/patternfly-f0d83b27e1 branch September 4, 2024 18:28
@martinpitt martinpitt mentioned this pull request Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasmatus tomasmatus tomasmatus approved these changes

@mvollmer mvollmer Awaiting requested review from mvollmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinpitt @jelly @tomasmatus