lib: isInline and isLiveRegion are wrongly typed #20772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Unit test failures are exactly the same in #20731 -- we broke main somehow? |
martinpitt
approved these changes
Jul 17, 2024
These properties have a default setting so are not required.
martinpitt
force-pushed
the
typescript-boo-typing
branch
from
6f9bbed to
0c30940
Compare
|
Rebased after landing the pytest fix. |
cockpituous
reviewed
Jul 18, 2024
| @@ -50,7 +50,7 @@ export const InlineNotification = ({ text, detail, type = "danger", onDismiss, i | |||
| ); | |||
|
|
|||
| return ( | |||
| <Alert variant={type || 'danger'} | |||
| <Alert variant={type} | |||
There was a problem hiding this comment.
This added line is not executed by any test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These properties have a default setting so are not required.
Headsup this current change will affect all cockpit-lib updates tomorrow. See cockpit-project/cockpit-files#659