new Channel API

.eslintrc.json

@@ -63,10 +63,30 @@
           "plugins": [
             "@typescript-eslint"
           ],
-          "extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended"],
+          "extends": "plugin:@typescript-eslint/recommended",
           "parser": "@typescript-eslint/parser",
           "parserOptions": {
             "project": ["./tsconfig.json"]
+          },
+          "rules": {
+            // https://typescript-eslint.io/rules/no-use-before-define
+            // Note: you must disable the base rule as it can report incorrect errors
+            "no-use-before-define": "off",
+            "@typescript-eslint/no-use-before-define": "error",
+
+            // as recommended by https://typescript-eslint.io/rules/no-unused-vars/
+            "@typescript-eslint/no-unused-vars": [
+              "error",
+              {
+                "args": "all",
+                "argsIgnorePattern": "^_",
+                "caughtErrors": "all",
+                "caughtErrorsIgnorePattern": "^_",
+                "destructuredArrayIgnorePattern": "^_",
+                "varsIgnorePattern": "^_",
+                "ignoreRestSiblings": true
+              }
+            ]
           }
         }
     ],

doc/guide/cockpit-channel.xml

@@ -242,12 +242,10 @@ cockpit.transport.close([problem])
   <refsection id="cockpit-transport-filter">
     <title>cockpit.transport.filter()</title>
 <programlisting>
-cockpit.transport.filter((message, channelid, control) =>  { ... }, [out])
+cockpit.transport.filter((message, channelid, control) =>  { ... })
 </programlisting>
     <para>Add a filter to the underlying channel transport. All incoming messages will be
-      passed to each of the filter callbacks that are registered. If the <code>out</code>
-      argument is equal to <code>true</code> then the filter will receive outgoing messages
-      that being sent on the underlying channel transport.</para>
+    passed to each of the filter callbacks that are registered.</para>
     <para>This function is rarely used.</para>
     <para>Filter callbacks are called in the order they are registered. If a filter
       callback returns <code>false</code> then the message will not be dispatched

files.js

@@ -47,6 +47,7 @@ const info = {
         "base1/test-browser-storage.js",
         "base1/test-cache.js",
         "base1/test-chan.js",
+        "base1/test-channel.ts",
         "base1/test-dbus-address.js",
         "base1/test-dbus-framed.js",
         "base1/test-dbus.js",

pkg/base1/test-chan.js

@@ -719,42 +719,6 @@ QUnit.test("filter message in", function (assert) {
     channel.send("three");
 });
 
-QUnit.test("filter message out", function (assert) {
-    const done = assert.async();
-    assert.expect(10);
-
-    let filtered = 0;
-    let filtering = true;
-    cockpit.transport.filter(function(message, channelid, control) {
-        if (!filtering)
-            return true;
-        if (message[0] == '\n') {
-            assert.strictEqual(channelid, "", "control message channel");
-            assert.equal(typeof control, "object", "control is a JSON object");
-            assert.equal(typeof control.command, "string", "control has a command");
-        } else {
-            assert.strictEqual(channelid, channel.id, "cockpit channel id");
-            assert.equal(control, undefined, "control is undefined");
-            filtered += 1;
-
-            if (filtered != 1) {
-                channel.close();
-                filtering = false;
-                done();
-                return false;
-            }
-
-            return true;
-        }
-        return false;
-    }, true);
-
-    const channel = cockpit.channel({ payload: "null" });
-    channel.send("one");
-    channel.send("two");
-    channel.send("three");
-});
-
 QUnit.test("inject message out", function (assert) {
     const done = assert.async();
     assert.expect(4);