test/static-code: tweak Typescript config again #20690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonkarlitskaya
added
the
no-test
martinpitt
reviewed
Jul 2, 2024
test/static-code
Outdated
| node_modules/.bin/tsc --checkJs false --skipLibCheck | ||
| # Only display tsc output if it contains errors about something other than node_modules/ | ||
| # https://github.com/microsoft/TypeScript/issues/30511 | ||
| if tsc --checkJs false --pretty false | grep -Eqv '^(node_modules| )'; then |
There was a problem hiding this comment.
Having `checkLib: false` in `tsconfig.conf` is a bad idea: it means that if we want to check `.d.ts` files, we need a separate invocation of the typescript compiler to do that. It also means that `.d.ts` files won't be checked in your editor by default. Our workaround for this in `test/static-code` only checks `cockpit.d.ts`, and we'll soon have other declaration files. We've been using `checkLib: false` as a crutch to avoid reporting errors against `node_modules/`. The relevant TypeScript issue is still unaddressed: microsoft/TypeScript#30511 Modify `test/static-code` to only report errors if errors were found on something outside of node_modules, but in that case, report all errors. We do this with two invocations of `tsc`, to keep things simple, but we'll only do the second invocation if we're reporting errors. To keep things speedy, we turn on "incremental" mode (which writes a cache file to speed things up). `.gitignore` that. It now takes only ~2s to do an incremental check in the "no errors" case. By default, `tsc` outputs a very nice format that shows the exact content of errors, but this doesn't work by default in `test/static-code` because we capture the output before displaying it. Detect if we're running on a TTY (or if `FORCE_COLOR=1` as from our workflows) and enable the "pretty" output in that case.
allisonkarlitskaya
force-pushed
the
tsc-once
branch
from
0225d28 to
e096427
Compare
Is ABRT being aborted? I faintly remember that someone said something about that at devconf, but I don't remember any details. This is Yet Another Pilot Thing™ |
allisonkarlitskaya
merged commit ffe6264
into
cockpit-project:main
29 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
checkLib: falseintsconfig.confis a bad idea: it means that if we want to check.d.tsfiles, we need a separate invocation of the typescript compiler to do that. It also means that.d.tsfiles won't be checked in your editor by default. Our workaround for this intest/static-codeonly checkscockpit.d.ts, and we'll soon have other declaration files.We've been using
checkLib: falseas a crutch to avoid reporting errors againstnode_modules/. The relevant TypeScript issue is still unaddressed: microsoft/TypeScript#30511Modify
test/static-codeto only report errors if errors were found on something outside of node_modules, but in that case, report all errors. We do this with two invocations oftsc, to keep things simple, but we'll only do the second invocation if we're reporting errors. To keep things speedy, we turn on "incremental" mode (which writes a cache file to speed things up)..gitignorethat. It now takes only ~2s to do an incremental check in the "no errors" case.By default,
tscoutputs a very nice format that shows the exact content of errors, but this doesn't work by default intest/static-codebecause we capture the output before displaying it. Detect if we're running on a TTY (or ifFORCE_COLOR=1as from our workflows) and enable the "pretty" output in that case.