Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: run unit-tests in the correct container #20169

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

allisonkarlitskaya
Copy link
Member

@allisonkarlitskaya allisonkarlitskaya commented Mar 13, 2024

Fixes #19986

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, nice!

Comment on lines +25 to +27
export FORCE_COLOR=1
export TEST_BROWSER=firefox
export CFLAGS=-O2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

podman run -e, but in the end it doesn't matter.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered it, but I prefer the way this looked.

@martinpitt martinpitt added the .github-changes Set by a reviewer just before landing to acknowledge that a PR changes github workflows label Mar 13, 2024
@allisonkarlitskaya allisonkarlitskaya merged commit da22d7a into main Mar 13, 2024
72 of 80 checks passed
@allisonkarlitskaya allisonkarlitskaya deleted the unit-tests-in-container branch March 13, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.github-changes Set by a reviewer just before landing to acknowledge that a PR changes github workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Python linting situation (pin versions)
2 participants