test: Drop rhel-8* from supported OSes, fix for ruff 0.3.1 (fixes failing "tox" test) #20149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That doesn't work any more, RHEL 8 testing now happens on the `rhel-8` branch.
|
Ah, the tox failure is due to new ruff 0.3.1, similar to what I just fixed in cockpit-project/bots#6035 . I'll fix it here. |
martinpitt
changed the title
martinpitt
requested review from
allisonkarlitskaya and
jelly
and removed request for
jelly and
allisonkarlitskaya
ruff 0.3.1, which now runs in our "tox" test, and which we will get with the next tasks container refresh), starts complaining about some .format() usages.
6 tasks
|
The /devel failure is a flake, but only in the 2nd retry. But primarily it is a failure with job-runner to upload coverage attachment, see cockpit-project/bots#6042 . This doesn't need to block landing this PR. |
martinpitt
changed the title
|
Re-running, as the "directory attachments" fix landed. |
allisonkarlitskaya
approved these changes
Mar 8, 2024
|
@allisonkarlitskaya I did it manually. I tried |
This was referenced Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That doesn't work any more, RHEL 8 testing now happens on the
rhel-8branch.This is primarily an excuse to work out our shiny new job-runner CI.