workflows: Run unit tests in our tasks container #20011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't support the C bridge on this branch any more.
We won't add a lot of new C code any more, valgrinding Python code isn't very useful (or architecture specific), and more and more distributions drop i386 support. Also, we still run the unit tests during RPM package build through packit/COPR, which cover even more architectures. This paves the way for dropping the unit test container altogether in favor of running the tests in the cockpit/tasks container, once we agree on how to build a proper staging setup. Drop tools/valgrind.supp which was only relevant for i386.
This reduces our tools like `ruff` to a single source of truth (as all our other projects already run their unit tests and linting in the tasks container). It also removes a lot of moving parts only relevant for CI. In practice, us developers run the unit tests in toolbox or our own dev machines anyway. Move building the guide in the release workflow to the tasks container as well.
martinpitt
added
the
no-test
|
I'll develop this against my branch, less noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces our tools like
ruffto a single source of truth (as allour other projects already run their unit tests and linting in the tasks
container). It also removes a lot of moving parts only relevant for CI.
In practice, us developers run the unit tests in toolbox or our own dev
machines anyway.
Move building the guide in the release workflow to the tasks container
as well.