test: Add tests for CPU and memory graph pages #13439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fail until landing PR #13438 |
martinpitt
added
the
blocked
|
The Oops on the graphs page is picked up by this new test as expected. |
martinpitt
added
needswork
and removed
blocked
|
Needs adjustment at least on fedora-coreos, as that doesn't have swap and thus uses a different memory graph. |
martinpitt
force-pushed
the
graphs-test
branch
from
a8ba0bd to
e0ad8f7
Compare
martinpitt
force-pushed
the
graphs-test
branch
from
e0ad8f7 to
73da792
Compare
|
Broken on rhel-8-2-distropkg, so I pushed a fix to skip the test there until the fix lands in our image. |
marusak
reviewed
Jan 24, 2020
| b.click("#link-cpu") | ||
| b.wait_not_visible(".ct-graph-memory") | ||
| b.wait_visible("#cpu_status_title") | ||
| b.wait_visible("#cpu_status_graph") |
There was a problem hiding this comment.
I thought that we are also going to check that the height (and width) is some reasonable number. Something like:
width = b.call_js_func('(function (sel) { return ph_find(sel).offsetWidth; })', "#cpu_status_graph")
There was a problem hiding this comment.
Cheers! I pushed the size check.
marusak
previously approved these changes
Jan 24, 2020
This makes sure that the page configures as expected and doesn't crash. Don't test the innards of the graph again, as they are exactly the same widgets as the ones already tested further above. But do ensure that they have a reasonable size. Reproduces https://bugzilla.redhat.com/show_bug.cgi?id=1792623 Closes cockpit-project#13439
martinpitt
force-pushed
the
graphs-test
branch
from
73da792 to
4d6e866
Compare
|
@marusak: Can you please re-review? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that the page configures as expected and doesn't crash.
Don't test the innards of the graph again, as they are exactly the same
widgets as the ones already tested further above.
Reproduces https://bugzilla.redhat.com/show_bug.cgi?id=1792623