lib/onoff: Don't write boolean attribute values into DOM #10007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They must be strings. The "enabled" attribute does not seem to have any effect anyway, the actual disabling happens with the <label> elements. Closes cockpit-project#10007
mvollmer
force-pushed
the
lib-onoff-no-DOM-booleans
branch
from
c59faa8 to
fc6fe3e
Compare
44 tasks
martinpitt
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They must be strings. The "enabled" attribute does not seem to have
any effect anyway, the actual disabling happens with the
elements.