Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machines: start vm checkbox is too large #8916

Closed
garrett opened this issue Mar 28, 2018 · 1 comment
Closed

machines: start vm checkbox is too large #8916

garrett opened this issue Mar 28, 2018 · 1 comment
Assignees

Comments

@garrett
Copy link
Member

garrett commented Mar 28, 2018

The "Immediately Start VM" checkbox is a bit too large:

screenshot-2018-3-28 ovirt machines - sunny 2

This is due to it pulling in the classes "form-control dialog-checkbox" that set height and width oddly (for a checkbox) on the #start-vm input.

Solutions (choose one):

  • Remove form-control and dialog-checkbox on the input element's class attribute

  • If you need the classes: in pkg/machines/machines.less, change height and width to unset, like so:

    .dialog-checkbox {
      width: unset;
      height: unset;
    }

    (Unset resets the CSS value to default.)

@atiratree atiratree self-assigned this Apr 24, 2018
martinpitt added a commit to martinpitt/cockpit that referenced this issue May 15, 2018
Drop the two classes and the now unused `dialog-checkbox` CSS, to get
the default checkbox size and layout. Neither class is being used at
runtime or in tests.

Fixes cockpit-project#8916
@martinpitt martinpitt assigned martinpitt and unassigned atiratree May 15, 2018
@martinpitt
Copy link
Member

I don't see that either class is actually necessary at runtime or for tests, so I just dropped these. Fix sent in PR #9177.

larskarlitski pushed a commit that referenced this issue May 16, 2018
Drop the two classes and the now unused `dialog-checkbox` CSS, to get
the default checkbox size and layout. Neither class is being used at
runtime or in tests.

Fixes #8916
Closes #9177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants