Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cockpit 278 #568

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Cockpit 278 #568

merged 1 commit into from
Oct 19, 2022

Conversation

jelly
Copy link
Member

@jelly jelly commented Oct 18, 2022

@jelly jelly force-pushed the cockpit-278 branch 2 times, most recently from e3b985d to b4df89b Compare October 19, 2022 14:21
@jelly jelly marked this pull request as ready for review October 19, 2022 14:22
@jelly jelly requested a review from garrett October 19, 2022 14:23
@jelly
Copy link
Member Author

jelly commented Oct 19, 2022

Waiting on gating of cockpit to update the bodhi links.

@garrett
Copy link
Member

garrett commented Oct 19, 2022

Notes mainly look good at a glance, but we should probably avoid repeating "X now supports Y when Z". I'll edit the text.

I've already modified the screen shot for create pod @ cockpit-project/cockpit-podman#961.

Should I do these edits in this PR now that it's not in preview mode?

garrett
garrett requested changes Oct 19, 2022
View reviewed changes
Copy link
Member

@garrett garrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a bunch of changes to the text. Screenshot update is pending and I'll update it in a moment.

_posts/2022-10-18-cockpit-278.md Outdated Show resolved Hide resolved
_posts/2022-10-18-cockpit-278.md Outdated Show resolved Hide resolved
_posts/2022-10-18-cockpit-278.md Show resolved Hide resolved
_posts/2022-10-18-cockpit-278.md Outdated Show resolved Hide resolved
_posts/2022-10-18-cockpit-278.md
![screenshot of ## ability to create new pod group]({{ site.baseurl }}/images/278-ability-to-create-new-pod-group.png)


![Screenshot from 2022-10-04 11-53-51]({{ site.baseurl }}/images/278-ability-to-create-new-pod-group-2.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an update to this screenshot, to make the framing more balanced. I'll modify it in the PR.

@jelly jelly merged commit f5c0606 into cockpit-project:main Oct 19, 2022
@jelly jelly deleted the cockpit-278 branch October 19, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrett garrett garrett requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jelly @garrett