-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pods (and some Ui refactoring) #468
Conversation
KKoukiou
commented
Jul 30, 2020
•
edited
Loading
edited
- fix tests
List of TODOs: (I'll convert them into issues when this PR lands)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing, thank you!
I wrote down list of follow-ups, please feel free to edit this list. I'll convert it into issues once this lands.
My main problem is with sorting and filtering. It seems to be container-centric, which sometimes does not make much sense (especially with owner).
Fixes cockpit-project#238 Closes cockpit-project#468
OK, so I've fixed the page's height (so it always stretches), fixed the stickiness of the filter bar, adjusted the spacing of the pods in all the scenarios I've encountered, and even included a Star Wars reference as a joke (that will be lost when this is squashed down 😉). @KKoukiou: I hope I didn't break anything in 628e995, when I removed a nested wrapper. |
Fixes cockpit-project#238 Closes cockpit-project#468
Thank you @KKoukiou for the changes, now it works much better!
So I have one rootless pod that is running and there are 2 running containers in it, but when I pick
EDIT: When I refresh the page it is fine. Is it possible that we don't recognize when pod state changes? (no event/no processed event) |
Added a HACK in our code and opened an issue to podman. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!