Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: Update moment package dependency #391

Merged
merged 1 commit into from
May 28, 2020
Merged

package.json: Update moment package dependency #391

merged 1 commit into from
May 28, 2020

Conversation

cockpituous
Copy link
Contributor

@cockpituous cockpituous commented May 26, 2020

Check for any outstanding update of point version of any outstanding NPM package dependency

  • npm-update

@cockpituous cockpituous changed the title Check for NPM dependency updates WIP: centosci-tasks-2tfcc: [no-test] Check for NPM dependency updates May 26, 2020
@cockpituous
Copy link
Contributor Author

npm-update in progress on centosci-tasks-2tfcc.
Log: https://logs-https-cockpit.apps.ci.centos.org/logs/npm-update-391-20200526-065252/

@cockpituous
Copy link
Contributor Author

@cockpituous cockpituous changed the title WIP: centosci-tasks-2tfcc: [no-test] Check for NPM dependency updates package.json: Update moment package dependency May 26, 2020
@cockpituous
Copy link
Contributor Author

Please manually check features related to these files:

package.json:    "moment": "2.26.0",
po/sk.po:msgstr "Kontajner momentálne beží."
src/ContainerDetails.jsx:const moment = require('moment');
src/ContainerDetails.jsx:        return cockpit.format(_("Up since $0"), moment(container.createdat, utils.GOLANG_TIME_FORMAT).calendar());
src/ContainerDetails.jsx:        <dd>{moment(container.createdat, utils.GOLANG_TIME_FORMAT).calendar()}</dd>
src/ImageDetails.jsx:const moment = require('moment');
src/ImageDetails.jsx:            <dd title={created.toLocaleString()}>{moment(created, utils.GOLANG_TIME_FORMAT).calendar()}</dd>
src/Images.jsx:const moment = require('moment');
src/Images.jsx:            moment(image.created, utils.GOLANG_TIME_FORMAT).calendar(),
src/app.jsx:import moment from "moment";
src/app.jsx:moment.locale(cockpit.language);
src/util.js: * this format specifier for converting that to moment.js time, e.g.:
src/util.js: *     moment(date, util.GOLANG_TIME_FORMAT)

@marusak
Copy link
Member

marusak commented May 26, 2020

example when test failed with coredump, but it was matched to naughty cockpit-project/bots#805

Lets investigate here

@marusak
Copy link
Member

marusak commented May 26, 2020

oh, because the last line does not contain not ok. Hmm...

@marusak marusak merged commit c8dacbf into cockpit-project:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants