New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert substr() usage to substring() #1913

Merged

martinpitt merged 1 commit into cockpit-project:main from jelly:substr-to-substring

Nov 21, 2024

Member

jelly commented Nov 21, 2024

String.prototype.substr() is a deprecated API.

Couldn't find an eslint rule for this, so we'll have to pay attention.


          Convert substr() usage to substring()

378924b

String.prototype.substr() is a deprecated API.

jelly requested a review from martinpitt

November 21, 2024 17:41

martinpitt approved these changes

View reviewed changes

Member

martinpitt left a comment

Dankjewel!

martinpitt merged commit ebc96f9 into cockpit-project:main

33 checks passed

jelly deleted the substr-to-substring branch

November 21, 2024 19:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet