Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Update Cockpit lib to b0e82161b4afcb9f0a6fddd8ff94380e #1908

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Jelle van der Waa (2):
lib: override PatternFly's secondary dark theme behaviour
test: disable multihost tests for Fedora CoreOS

Marius Vollmer (1):
test: Fix coverage report for pkg/lib

Martin Pitt (1):
lib: Drop watching in credentials.js

tomasmatus (4):
lib: pam_user_parser.ts add return types
lib: python.ts add exception type
lib: check for null instead of undefined
lib: add types to more cockpit-components

@github-actions github-actions bot added the bot label Nov 14, 2024
@github-actions github-actions bot changed the title [no-test] Makefile: Update Cockpit lib to b0e82161b4afcb9f0a6fddd8ff94380e Makefile: Update Cockpit lib to b0e82161b4afcb9f0a6fddd8ff94380e Nov 14, 2024
@allisonkarlitskaya allisonkarlitskaya force-pushed the cockpit-lib-update-cockpit-lib-20241114-024547 branch from fd05af3 to 1697e75 Compare November 14, 2024 02:45
@martinpitt
Copy link
Member

Uh, eslint errors... Not sure how the cockpit lib update changed that, but they look legit.

@jelly
Copy link
Member

jelly commented Nov 14, 2024

Uh, eslint errors... Not sure how the cockpit lib update changed that, but they look legit.

We switched that component from JSX to TSX

Move the file extension imports along
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we don't have to specify file extensions at all, no? Thanks!

@martinpitt martinpitt merged commit c43222b into main Nov 14, 2024
33 of 34 checks passed
@martinpitt martinpitt deleted the cockpit-lib-update-cockpit-lib-20241114-024547 branch November 14, 2024 09:35
@jelly
Copy link
Member

jelly commented Nov 14, 2024

Hmm, we don't have to specify file extensions at all, no? Thanks!

Uh it depends, I think. Seems not by testing but now too late :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants