Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appstream: Fix validation problems #1874

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Oct 10, 2024

Rename the file to match its ID, add developer/home page, and extend the
description. This fixes all issues with appstreamcli validate:

W: org.cockpit_project.podman: url-homepage-missing
W: org.cockpit_project.podman: metainfo-filename-cid-mismatch
I: org.cockpit_project.podman:38: description-first-para-too-short
I: org.cockpit_project.podman: developer-info-missing


See https://appstream.debian.org/sid/main/issues/cockpit-podman.html . metainfo-filename-cid-mismatch is new with the recent update of AppStream to 1.0.3 in Debian. See also cockpit-project/cockpit#21103

Rename the file to match its ID, add developer/home page, and extend the
description. This fixes all issues with `appstreamcli validate`:

> W: org.cockpit_project.podman:~: url-homepage-missing
> W: org.cockpit_project.podman:~: metainfo-filename-cid-mismatch
> I: org.cockpit_project.podman:38: description-first-para-too-short
> I: org.cockpit_project.podman:~: developer-info-missing
@martinpitt
Copy link
Member Author

Once that's in, I'll give a similar treatment to machines and friends.

@martinpitt martinpitt requested a review from jelly October 10, 2024 08:07
Copy link
Member

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jelly jelly merged commit 40dfae2 into cockpit-project:main Oct 10, 2024
34 checks passed
@martinpitt martinpitt deleted the appstream branch October 10, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants