test: wait on the dialog to close #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TBH I don't understand the commit message. How is that related to a dialog and tearing down? In that case we should wait for the dialog to go away -- that's sorely missing and should be done in any case. Then the container should be guaranteed to run. |
Right, that is true. I think it is also a good thing to check if the container is actually running |
martinpitt
changed the title
martinpitt
requested changes
Mar 18, 2024
Wait until the dialog is closed before opening it again, this allows us to remove the hacky `podman inspect` workaround to wait till the container is running intended to achieve the same as waiting for the dialog to close.
This comment was marked as outdated.
This comment was marked as outdated.
martinpitt
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podman inspect seems to fail randomly when we just created a container, likely because it is still "setting up". As we try to work around the issue where we click too fast on the "create container" button while the dialog is still tearing down, we aren't too interested in much of podman inspect more in if the container is running.