Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: avoid a double wait_visible #1614

Merged
merged 1 commit into from
Mar 13, 2024
Merged

test: avoid a double wait_visible #1614

merged 1 commit into from
Mar 13, 2024

Conversation

jelly
Copy link
Member

@jelly jelly commented Mar 13, 2024

The click and wait_in_text function already call wait_visible so we end up waiting twice.

@jelly
test: avoid a double wait_visible
a08f538 
The click and wait_in_text function already call wait_visible so we end
up waiting twice.
@jelly jelly marked this pull request as ready for review March 13, 2024 16:51
@jelly jelly requested a review from martinpitt March 13, 2024 16:52
martinpitt
martinpitt approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinpitt martinpitt merged commit 00ff310 into cockpit-project:main Mar 13, 2024
29 of 30 checks passed
@jelly jelly deleted the avoid-double-wait branch March 13, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpitt martinpitt martinpitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jelly @martinpitt