Use Cockpit's Kebab dropdown #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly
force-pushed
the
kebab-dropdown
branch
3 times, most recently
from
f936f93 to
c1c0fd0
Compare
jelly
commented
Mar 6, 2024
test/check-application
Outdated
| @@ -916,7 +916,7 @@ class TestApplication(testlib.MachineCase): | |||
|
|
|||
| # Delete intermediate image which is in use | |||
| self.execute(auth, f"podman untag {IMG_INTERMEDIATE}") | |||
| b.click(intermediate_image_sel + " .pf-v5-c-dropdown__toggle") | |||
| b.click(intermediate_image_sel + " .pf-v5-c-menu-toggle") | |||
There was a problem hiding this comment.
Maybe we should just use a .... helper function
There was a problem hiding this comment.
This becomes more and more of a yakshave as we repeat the same stuff in deleteImage... This feels follow up territory.
Ideally we would also refactor `deleteImage` in `DownloadImageDialog` but that requires some more work.
martinpitt
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.