Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packit: Build COPR for main commits #1365

Merged
merged 1 commit into from
Jul 31, 2023
Merged

packit: Build COPR for main commits #1365

merged 1 commit into from
Jul 31, 2023

Conversation

martinpitt
Copy link
Member

Build every commit into main into
https://copr.fedorainfracloud.org/coprs/g/cockpit/main-builds/

We will use that for cross-project testing (e.g. running cockpit-podman's tests in podman upstream PRs). Users can also install that to test bug fixes and new features after they landed, but before they got released.


See cockpit-project/cockpit#19117 (comment) for the plan.

@martinpitt
Copy link
Member Author

@lachmanfrantisek, @lbarcziova : I'm a bit confused here. This already triggered rpm-build:main-build-copr* tasks, but this PR didn't land yet. Shouldn't this only trigger after a PR lands? I did set branch: main in packit.yaml, did I screw this up somehow? I thought I followed https://packit.dev/docs/configuration/upstream/copr_build#optional-parameters

@lbarcziova
Copy link
Contributor

@martinpitt I think the problem here is that the source branch of this PR is named main-* and we do re.match() when checking the match in the configuration, therefore there are additional checks for the main-build-copr branch

@martinpitt
Copy link
Member Author

@lbarcziova Erk, right; If that's a regexp, I just make it tighter. TIL!

@martinpitt
Copy link
Member Author

@lbarcziova Yes, that was it -- with this change I don't get the copr jobs any more.

That said, this error was actually useful, as the build failed. I'll revert back to the "broken" version again to fix the build first.

@martinpitt
Copy link
Member Author

martinpitt commented Jul 31, 2023

COPR build succeeded, so switching back to the tight and correct branch:.

Update: I deleted that COPR build, as I don't want to clutter it with test builds which were not actually from main.

Build every commit into main into
https://copr.fedorainfracloud.org/coprs/g/cockpit/main-builds/

We will use that for cross-project testing (e.g. running
cockpit-podman's tests in podman upstream PRs). Users can also install
that to test bug fixes and new features after they landed, but before
they got released.
@martinpitt martinpitt marked this pull request as ready for review July 31, 2023 09:34
@martinpitt martinpitt requested a review from jelly July 31, 2023 09:35
@martinpitt martinpitt merged commit d426611 into main Jul 31, 2023
@martinpitt martinpitt deleted the main-build-copr branch July 31, 2023 10:36
@martinpitt
Copy link
Member Author

Cool, I got a build! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants